@andrerom
andrerom commented on pull request ezsystems/CommentsBundle#34 Feb 26, 2019

Assuming the class_exists* check works now, I guess we can re-add these two as we ended up not bumping requirements. * side: there should be a way …

02/26/2019 09:13 am   André @ GitHub   Mirror   Link  
@bdunogier
bdunogier pushed to l10n_master in ezsystems/ezplatform-i18n Feb 26, 2019
1 commit to l10n_master
  • @bdunogier bbaa2b1
    New translations universal_discovery_widget.xlf (French)
02/26/2019 08:21 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@bdunogier
bdunogier pushed to l10n_master in ezsystems/ezplatform-i18n Feb 26, 2019
1 commit to l10n_master
  • @bdunogier df353bc
    New translations universal_discovery_widget.xlf (French)
02/26/2019 08:11 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@bdunogier
bdunogier pushed to l10n_master in ezsystems/ezplatform-i18n Feb 26, 2019
1 commit to l10n_master
  • @bdunogier 5352c7c
    New translations universal_discovery_widget.xlf (French)
02/26/2019 08:02 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@bdunogier
bdunogier pushed to l10n_master in ezsystems/ezplatform-i18n Feb 26, 2019
1 commit to l10n_master
  • @bdunogier 86243bd
    New translations content_url.xlf (French)
02/26/2019 07:51 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@bdunogier
bdunogier pushed to l10n_master in ezsystems/ezplatform-i18n Feb 26, 2019
1 commit to l10n_master
  • @bdunogier db7f198
    New translations drafts.xlf (French)
02/26/2019 07:42 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@andrerom
andrerom pushed to master in ezsystems/ezplatform-solr-search-engine Feb 26, 2019
2 commits to master
  • @andrerom 2f682f0
    Merge branch '1.5'
  • @mateuszbieniek f2c1308
    Changed composer.json so correct kernel version is used for eZ Platfo…
02/26/2019 06:36 am   André @ GitHub   Mirror   Link  
@andrerom
andrerom pushed to 1.5 in ezsystems/ezplatform-solr-search-engine Feb 26, 2019
1 commit to 1.5
  • @mateuszbieniek f2c1308
    Changed composer.json so correct kernel version is used for eZ Platfo…
02/26/2019 06:35 am   André @ GitHub   Mirror   Link  
@andrerom
andrerom merged a pull request in ezsystems/ezplatform-solr-search-engine Feb 26, 2019
Required kernel for eZ Platform 1.7 should be 6.7.10+ #132

Current tagged kernel 6.7 is 6.7.9.1 which does not contain changes required by 55558b7 same for 6.13 This PR changes the requirement for kernel 6.…

+1 -1
02/26/2019 06:35 am   André @ GitHub   Mirror   Link  
@andrerom
andrerom commented on pull request ezsystems/ezplatform-solr-search-engine#130 Feb 26, 2019

It won't help unless we delete 1.5.6 tag which is so so risky.. maybe we need to fast track 6.7 kernel release?

02/26/2019 06:29 am   André @ GitHub   Mirror   Link  
@bdunogier
bdunogier commented on pull request ezsystems/ezplatform-graphql#8 Feb 26, 2019

Isn't it an array of SortClause objects ?

02/26/2019 06:17 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@bdunogier
bdunogier commented on pull request ezsystems/ezplatform-graphql#8 Feb 26, 2019

This class must be made abstract. Also, since it is abstract, it would require a phpdoc comment that explains how it is implemented.

02/26/2019 06:14 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@bdunogier
bdunogier commented on pull request ezsystems/ezplatform-graphql#8 Feb 26, 2019

This should be changed to an exception. You could add a new one to the package, in src/Exceptions. Maybe InvalidQueryOperatorException ?

02/26/2019 06:14 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@bdunogier
bdunogier commented on pull request ezsystems/ezplatform-graphql#8 Feb 26, 2019

I actually wouldn't use a class constant for that. It doesn't deduplicate much, and does so at the cost of readability. I'd use SearchQueryMapper::…

02/26/2019 06:08 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@gggeek
gggeek commented on pull request ezsystems/ezpublish-kernel#2549 Feb 26, 2019

Not that I am a fan of 'special casing', but eZ already has (or at least had in eZ4 times) code that treated 'ez_lock' state as 'built-in' and disa…

02/26/2019 05:24 am   Gaetano @ GitHub   Mirror   Link  
@bdunogier
bdunogier commented on pull request ezsystems/ezplatform-graphql#8 Feb 26, 2019

Given that it is reusable, this one would deserve a phpdoc comment explaining how it is used. Also, I know that I suggested the initial name, but S…

02/26/2019 05:18 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@emodric
emodric pushed to master in netgen/ezplatform-sylius Feb 26, 2019
1 commit to master
  • @emodric 7693b65
    Add Sylius specific config for dev and prod environments
02/26/2019 04:40 am   Edi @ GitHub   Mirror   Link  
@emodric
emodric pushed to master in netgen/ezplatform-sylius Feb 26, 2019
2 commits to master
02/26/2019 04:26 am   Edi @ GitHub   Mirror   Link  
@gggeek
gggeek commented on pull request ezsystems/ezpublish-kernel#2549 Feb 26, 2019

@Nattfarinn your usecase seems nice, I agree. But it wonder if it could be achieved with the existing content model, fe. having a button in the GUI…

02/26/2019 03:45 am   Gaetano @ GitHub   Mirror   Link  
@andrerom
andrerom pushed to master in ezsystems/LegacyBridge Feb 26, 2019
2 commits to master
02/26/2019 03:40 am   André @ GitHub   Mirror   Link