@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
05/04/2018 08:20 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
05/04/2018 08:07 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
05/04/2018 07:29 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
05/04/2018 07:01 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
05/04/2018 06:40 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
05/04/2018 06:19 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
  • @gggeek 2b894b8
    add to testing matrix ezplatfom 2
05/04/2018 05:34 am   Gaetano @ GitHub   Mirror   Link  
@andrerom
andrerom commented on pull request ezsystems/ezplatform-xmltext-fieldtype#39 May 4, 2018

could remove this as class property and rather inject it, to avoid global state set by method which is not a setter.

05/04/2018 02:59 am   André @ GitHub   Mirror   Link  
@andrerom
andrerom commented on pull request ezsystems/ezplatform-xmltext-fieldtype#39 May 4, 2018

Seems we need NullLogger here to form the looks of the new code bellow.

05/04/2018 02:56 am   André @ GitHub   Mirror   Link  
@andrerom
andrerom commented on pull request ezsystems/ezplatform-xmltext-fieldtype#39 May 4, 2018

Could also be: $this->logger = $logger instanceof LoggerInterface ? $logger : new NullLogger();

05/04/2018 02:54 am   André @ GitHub   Mirror   Link  
@ezecosystem
ezecosystem pushed to master in ezecosystem/launchpad May 4, 2018
05/04/2018 12:01 am   eZecosystem @ GitHub   Mirror   Link  
@ezecosystem
ezecosystem pushed to master in ezecosystem/ezmigrationbundle May 4, 2018
05/03/2018 11:58 pm   eZecosystem @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezloremipsumbundle May 4, 2018
  • @gggeek aac055b
    move Loop executor into the main Migration bundle
05/03/2018 07:29 pm   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek pushed to master in kaliop-uk/ezmigrationbundle May 4, 2018
05/03/2018 07:28 pm   Gaetano @ GitHub   Mirror   Link  
@crevillo
crevillo commented on issue kaliop-uk/ezmigrationbundle#159 May 3, 2018

Yes. Probably I missunderstood. I thought you was talking about getting language from the admin siteaccess in case --lang not passed. But reading i…

05/03/2018 04:20 pm   Carlos @ GitHub   Mirror   Link  
@gggeek
gggeek commented on issue kaliop-uk/ezmigrationbundle#159 May 3, 2018

@crevillo but in that case would you have set up as default siteaccess one that has the 'main' content language as its 1st language ?

05/03/2018 04:10 pm   Gaetano @ GitHub   Mirror   Link  
@andrerom
andrerom commented on pull request ezsystems/ezpublish-kernel#2320 May 3, 2018

How was terminate="yes" behaving? Omitting the tag, or terminating the whole transformation?

05/03/2018 02:18 pm   André @ GitHub   Mirror   Link  
@crevillo
crevillo commented on issue kaliop-uk/ezmigrationbundle#159 May 3, 2018

can we assume that devs are smart enough to run migrations using an admin siteaccess? well, take in account that somebody (as me) could be using e…

05/03/2018 01:57 pm   Carlos @ GitHub   Mirror   Link  
@gggeek
gggeek commented on issue kaliop-uk/ezmigrationbundle#46 May 3, 2018

NB: a new bundle is in the works for this: https://github.com/kaliop-uk/ezloremipsumbundle Some of the required functionality will be part of migra…

05/03/2018 11:54 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek commented on issue kaliop-uk/ezmigrationbundle#117 May 3, 2018

nb: this is getting easier in version 4.8: you should now be able to define a field structure as reference, and use it for any field definition

05/03/2018 11:52 am   Gaetano @ GitHub   Mirror   Link  
@gggeek
gggeek opened an issue in kaliop-uk/ezmigrationbundle May 3, 2018
Do not use hardcoded eng-gb as default language but take the 1st lang of current siteaccess #159

It often happens that developers that use an admin siteaccess where the main lang is not eng-GB are often caught in a trap because they do not use …

05/03/2018 11:45 am   Gaetano @ GitHub   Mirror   Link  
@bdunogier
bdunogier commented on pull request ezsystems/ezpublish-kernel#2311 May 3, 2018

While having that feature in a separate package benefits older versions, it feels like it is too little. I'd tend to agree with @andrerom about hav…

05/03/2018 08:44 am   Bertrand Dunogier @ GitHub   Mirror   Link  
@emodric
emodric commented on pull request ezsystems/ezpublish-kernel#2317 May 3, 2018

In any case, how would renaming Criterion to Matcher help anyone? It is just creating a BC break for the sake of breaking BC. Developers are alread…

05/03/2018 07:55 am   Edi @ GitHub   Mirror   Link  
@dpobel
dpobel deleted branch veille_18-2018 at dpobel/damien.pobel.fr May 3, 2018
05/03/2018 06:52 am   Damien @ GitHub   Mirror   Link  
@dpobel
dpobel merged a pull request in dpobel/damien.pobel.fr May 3, 2018
+23 -1
1 comment
05/03/2018 06:52 am   Damien @ GitHub   Mirror   Link  
@dpobel
dpobel pushed to master in dpobel/damien.pobel.fr May 3, 2018
05/03/2018 06:52 am   Damien @ GitHub   Mirror   Link